Amplitude-Magnitude Regression #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damb
added
enhancement
damb
force-pushed
the
feature/amplitude-magnitude-regression
branch
8 times, most recently
from
71f3ad4
to
8744f09
Compare
damb
force-pushed
the
feature/amplitude-magnitude-regression
branch
2 times, most recently
from
73153da
to
18bea38
Compare
damb
force-pushed
the
feature/amplitude-magnitude-regression
branch
from
18bea38
to
1e70f3c
Compare
damb
force-pushed
the
feature/amplitude-magnitude-regression
branch
from
1e70f3c
to
b95e5b0
Compare
added 13 commits
November 29, 2021 17:07
Do not use the Status as in `WaveformProcessor`. Instead wrap the status into an magnitude processor specific exception.
The purpose of this class is to handle a template family configuration.
A template family configuration is a container for `ReferenceConfig`s
i.e. configuration referencing a template family member. At the time
being a reference configuration may:
- reference a stream configuration from a detector configuration
(indirection)
- reference a sensor location which is NOT used for detection, but
used anyway for the template family based *amplitude-magnitude*
regression.
Do not use boilerplate template `AnyFixedSlopeRegressionMagnitude`. Instead, `std::ratio<>` straight away in `FixedSlopeRegressionMagnitude`. Therefore, `FixedSlopeRegressionMagnitude` is the template, now.
Provide dedicated exception.
|
Ok, almost done - I know, it took quite a while. Though, there is still kind of a bug when it comes to computing the magnitude. As a consequence a small unexpected offset is introduced. I'll have a look into it, tomorrow. |
|
Ok. It should be fixed now. There is still the remaining issue that the taper length is not included to the amplitude processor's safety time window. I'll fix this as part of another PR. |
damb
force-pushed
the
feature/amplitude-magnitude-regression
branch
3 times, most recently
from
e235d22
to
445a12f
Compare
added 19 commits
December 8, 2021 13:05
Trim only if the difference is greater than or equal to a single sample.
Note that it of course matters which data is passed to the `deconvolveData()` method. - Compute the trend from the correct time window. - Apply the response to the correct time window. Note that the response is applied to the full dataset in frequency domain. There is still a remaining issue regarding the preprocessing. That is, the taper length should be included to the amplitude processor's safety margin.
Describe template family based amplitude-magnitude regression approach.
Disable magnitude processing. Note that currently, the integration test facilities do neither test amplitude calculation nor do they test the magnitude estimation. Though, it would be good if these facilities would be tested, appriopriately.
Allow magnitudes to be configurable on sensor location granularity.
`calculateAmpltiudes` -> `createAmplitudes` `calculateMagnitues` -> `createMagnitudes`
Do not allow the configuration of magnitude types on detector level granularity. Both amplitude types and magnitude types are going to configured with bindings (i.e. on sensor location level granularity). Implement a standalone function in order to extract the sensor location stream indentifier from the `util::WaveformID`. Correctly parse and forward magnitude related publish configuration.
When creating `util::WaveformID` an exception is thrown, anyway, if the parameters supplied are not valid.
|
@mmesim, ready to go. It's time to give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
scdetectis able to estimate magnitudes based on a template family amplitude-magnitude regression approach (for further information please refer to https://doi.org/10.1029/2019JB017468).Features and Changes:
template-families.jsonconfiguration file (Template family configuration requirements #50).--templates-family-json path/to/templates-family.jsonand the--magnitudes-force=0|1(in accordance to the--amplitudes-force) CLI flagsDataModel::StationMagnitude(which in fact are sensor location magnitudes)MLxamplitudesconfignamespaceReferences: #50