Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different timezone causes checks to skip merge requests #28

Open
edtan opened this issue Dec 9, 2018 · 0 comments
Open

Different timezone causes checks to skip merge requests #28

edtan opened this issue Dec 9, 2018 · 0 comments

Comments

@edtan
Copy link

edtan commented Dec 9, 2018

I'm on an older version of GitLab - v10.8.3 - and the commits API returns the committed_date using the committer's time zone. e.g. "2018-12-06T17:17:38.214-05:00". However, the latest version of GitLab looks like it's returning the timezone in UTC ("2018-12-06T16:08:35.000Z", src).

check currently checks the first 19 characters of committed_date, which works if all times are returned in UTC. However, this causes the check to miss particular merge requests when the commits are in different zones (with older versions of GitLab). I can't seem to find which release of GitLab changed the committed_date format, but I believe it's related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant