removal of forProvider.name, fix http resp code 400 in the start of creating and some small enchantments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleahu
changed the base branch from
feature/servicecatalog-provisioned-product-resource
to
development
mleahu
changed the title
teeverr
changed the title
teeverr
commented
Oct 5, 2023
| // If the product is undergoing change, we want to assume that it is not up-to-date. This will force this resource | ||
| // to be queued for an update (which will be skipped due to UNDER_CHANGE), and once that update fails, we will | ||
| // recheck the status again. This will allow us to quickly transition from UNDER_CHANGE to AVAILABLE without having | ||
| // to wait for the entire polling interval to pass before re-checking the status. | ||
| if pointer.StringDeref(ds.Status.AtProvider.Status, "") == string(svcapitypes.ProvisionedProductStatus_SDK_UNDER_CHANGE) { |
There was a problem hiding this comment.
ds doesn't contain anything in ds.Status.AtProvider, it will be be set later. that is why I replace it to resp.ProvisionedProductDetail.Status
|
@teeverr all good from my side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested