Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cypress acceptance tests more robust to previous failures #3009

Closed
ciyer opened this issue Mar 21, 2023 · 1 comment · Fixed by #3053
Closed

Make cypress acceptance tests more robust to previous failures #3009

ciyer opened this issue Mar 21, 2023 · 1 comment · Fixed by #3053
Assignees

Comments

@ciyer
Copy link
Contributor

ciyer commented Mar 21, 2023

Sometimes a cypress acceptance test runs and leaves a zombie session around that causes problems for later runs.

We should make the logic that connects to a session also consider the project (which should be unique per run), since this will make the test more robust.

@lorenzo-cavazzi
Copy link
Member

To add more context: we are checking that we can start a session on a project, and terminate it. We give it for granted that no other sessions should be running. This fails when another process leaves sessions (e.g. something failed and the previous session is still running).

We should update the logic so that:

  • We actually verify no sessions for the specific project we are working with are running before starting a new session there. If that's not the case, we should terminate them beforehand.
  • Verify the tests check only running sessions for the target project, not all the test user sessions.

@leafty leafty self-assigned this May 2, 2023
leafty added a commit that referenced this issue May 2, 2023
Close all running sessions in `useSession.cy.ts` before running the
tests. This should fix zombie sessions making tests fail.

Fixes #3009.
leafty added a commit that referenced this issue May 5, 2023
)

Close all running sessions in `useSession.cy.ts` before running the
tests. This should fix zombie sessions making tests fail.

Fixes #3009. 

---------

Co-authored-by: Lorenzo <lorenzo.cavazzi.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants