Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button update Figma #1571

Closed
5 tasks done
gfellerph opened this issue Jun 28, 2023 · 2 comments
Closed
5 tasks done

Button update Figma #1571

gfellerph opened this issue Jun 28, 2023 · 2 comments
Assignees

Comments

@gfellerph
Copy link
Member

gfellerph commented Jun 28, 2023

As discussed in #1566

Tasks

@wueestd
Copy link

wueestd commented Jul 19, 2023

Hi @imagoiq we adjusted the button font size but also changed the paddings and gaps: https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components-Post?type=design&node-id=10576%3A49992&mode=design&t=7oqrnfHBJ8pn1R7p-1

Can you have a look at this and add it to the PR? If you have any questions about it the next few days, please contact @rouvenpost

@imagoiq
Copy link
Contributor

imagoiq commented Jul 20, 2023

@wueestd @rouvenpost I saw the padding changes. We need to discuss it. Size 40 and 56 use respectively 14px and 18px. We don't support those values currently with the spacing (only 4 by 4px so 12, 16, 20, 24…). I don't see either any change in that regard in this proposal #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants