Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Text Input #802

Closed
wueestd opened this issue Nov 23, 2022 · 11 comments
Closed

Optimize Text Input #802

wueestd opened this issue Nov 23, 2022 · 11 comments
Assignees
@gfellerph

Comments

@wueestd
Copy link

wueestd commented Nov 23, 2022

https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7775%3A33876&t=zTAKJLbklgpXEsSf-1
@wueestd wueestd self-assigned this Nov 23, 2022
@wueestd
Copy link
Author

wueestd commented Nov 23, 2022 •
edited
Loading

UX Tasks:

  • validation state
  • do we need a extra small variant?

@wueestd wueestd assigned gfellerph and unassigned wueestd Nov 23, 2022
@gfellerph
Copy link
Member

gfellerph commented Nov 24, 2022 •
edited
Loading

Placeholders
There is no placeholder in the floating label implementation when the focus is on the field
Image
Design:
Image

Mismatching height variants

Height Design Implementation
72px ✔ ✔
54.4px ❌ ✔
48px ✔ ❌
46.4px ❌ ✔
35.5px ❌ ✔

I suggest sticking with the design.

Error message
We should discuss moving the exclamation mark to the message.

Changes described in #807.

@wueestd wueestd self-assigned this Dec 7, 2022
@gfellerph
Copy link
Member

Dev:

  • Show placeholder when label is floated and input is empty

@gfellerph gfellerph mentioned this issue Dec 7, 2022
Closed
@gfellerph gfellerph removed their assignment Dec 7, 2022
@wueestd wueestd assigned gfellerph and unassigned wueestd Jan 10, 2023
@wueestd
Copy link
Author

wueestd commented Jan 10, 2023

ready for second review @gfellerph https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=7775%3A33876&t=zTAKJLbklgpXEsSf-1

@gfellerph
Copy link
Member

I created a dev ticket and updated the figma status for this component to done.

@wueestd wueestd assigned wueestd and unassigned gfellerph Feb 6, 2023
@wueestd
Copy link
Author

wueestd commented Feb 8, 2023 •
edited
Loading

  • Sufix adaption in figma

@wueestd wueestd assigned gfellerph and unassigned wueestd Feb 15, 2023
@gfellerph
Copy link
Member

gfellerph commented Feb 27, 2023 •
edited
Loading

  • create tickets for suffix/postfix

@gfellerph
Copy link
Member

@wueestd would you like to visualize cases for prefix and suffix on the right? While it is implemented, it would maybe be good for overview when somebody visits the component page and can see all the different variants of this component.

@gfellerph
Copy link
Member

  • Suffix fixen
  • Creates examples with prefix, suffix and both

@gfellerph gfellerph assigned wueestd and unassigned gfellerph Mar 6, 2023
@wueestd
Copy link
Author

wueestd commented Mar 7, 2023

@gfellerph does this help? https://www.figma.com/file/xZ0IW0MJO0vnFicmrHiKaY/Components?node-id=10627%3A52548&t=oHGE1KDZe20h8aqg-1

@wueestd wueestd assigned gfellerph and unassigned wueestd Mar 7, 2023
@gfellerph
Copy link
Member

Created dev tasks and update component tracker board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gfellerph gfellerph

Labels
None yet
Projects
Design System Production Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfellerph @wueestd