You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Properties like requesturl and destination could be good candidates to search for.
Hook search API
Adopt the HookHandler class (or a suitable other handler) to handle hook searching requests.
These requests could look something like this:
Wouldn't it be simpler to just add a query parameter to the routes/listeners resources?
Like GET /gateleen/server/hooks/v1/registrations/routes/?q=batchAdd
The only meaningful field to search in is the destination. We can do a full-text search on it.
This way we can easily use that in the browser for a quick search and also build a beautiful UI search field with suggestions as you type.
I thought about query parameters too but avoided them because regex patterns could not be defined. There could be more fields to search for like for example x-queue-headers which are set or something else. We could in fact just provide a single query parameter (q) and search over all fields in the resource with a full-text search. WDYT?
I fear a bit of overengineering. Regexp are not necessary, I think.
I don't see a use case for searching in headers as well. I propose to keep searching only in destination. We can still extend this later (e.g. using a additonal parameter fullText).
As far as I understand, this is just something to help devs and ops.
With the current implementation, hooks (in the storage) can be searched by calling the configured hook uri. For example:
Hooks can only be found based on the names and encoded urls shown in the examples above.
Looking at a specific hook, there are more information which could be useful to search for:
Properties like requesturl and destination could be good candidates to search for.
Hook search API
Adopt the HookHandler class (or a suitable other handler) to handle hook searching requests.
These requests could look something like this:
The text was updated successfully, but these errors were encountered: