Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable @swissquote/swissquote/react/prop-types if strict mode is enabled #2216

Closed
onigoetz opened this issue Oct 27, 2023 · 1 comment
Closed

Disable @swissquote/swissquote/react/prop-types if strict mode is enabled #2216

onigoetz opened this issue Oct 27, 2023 · 1 comment
Labels
category/bug status/to-release

Comments

@onigoetz
Copy link
Member

Sometimes we get warnings like :

14:48  warning  'className' is missing in props validation  @swissquote/swissquote/react/prop-types

apparently already documented in : jsx-eslint/eslint-plugin-react#3325

This rule seems to be redundant when TypeScript's Strict mode is enabled

Check if it's possible to disable it for TypeScript when strict checking is enabled (As TS would catch that anyway)
onigoetz added a commit that referenced this issue Feb 27, 2024
@onigoetz
Disable prop-types for TypeScript #2216
c43fe4f
@onigoetz
Copy link
Member Author

released Released in https://github.com/swissquote/crafty/releases/tag/v1.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/bug status/to-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onigoetz