Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate all core translation files upon translation update #116

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

swissspidy
Copy link
Owner

Core is a special case because translations are split up in multiple files.

Upon translation updates only the main file was updated, but not the others.

@swissspidy swissspidy added the bug Something isn't working label Nov 9, 2023
@swissspidy swissspidy added this to the 1.0.7 milestone Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #116 (28d2c48) into main (9e07ffd) will increase coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 95.45%.

@@             Coverage Diff              @@
##               main     #116      +/-   ##
============================================
+ Coverage     95.29%   95.34%   +0.05%     
- Complexity      181      182       +1     
============================================
  Files             6        6              
  Lines           425      430       +5     
============================================
+ Hits            405      410       +5     
  Misses           20       20              
Flag Coverage Δ
default 95.34% <95.45%> (+0.05%) ⬆️
multisite 32.55% <90.90%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/class-ginger-mo.php 96.77% <100.00%> (ø)
lib/class-performant-translations.php 97.67% <95.23%> (+0.14%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@swissspidy swissspidy enabled auto-merge (squash) November 9, 2023 14:19
@swissspidy swissspidy merged commit e440561 into main Nov 9, 2023
24 checks passed
@swissspidy swissspidy deleted the fix/core-split-files branch November 9, 2023 14:19
@swissspidy
Copy link
Owner Author

Performance Test Results

Performance test results for fba86f9 are in 🛎️!

WordPress Admin

Locale Scenario wp-memory-usage wp-total
en_US Default 17.43 MB 188.84 ms
de_DE Default 34.27 MB 257.54 ms
de_DE Ginger MO (MO) 22.00 MB 234.13 ms
de_DE Ginger MO (PHP) 18.90 MB 201.45 ms

Twenty Twenty-Three

Locale Scenario wp-memory-usage wp-total
en_US Default 16.30 MB 180.37 ms
de_DE Default 29.97 MB 240.76 ms
de_DE Ginger MO (MO) 19.86 MB 226.61 ms
de_DE Ginger MO (PHP) 17.52 MB 191.81 ms

Twenty Twenty-One

Locale Scenario wp-memory-usage wp-total
en_US Default 15.79 MB 151.63 ms
de_DE Default 29.56 MB 209.72 ms
de_DE Ginger MO (MO) 19.37 MB 191.81 ms
de_DE Ginger MO (PHP) 17.02 MB 156.82 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant