Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parsed flag as early as possible #79

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Set parsed flag as early as possible #79

merged 3 commits into from
Sep 6, 2023

Conversation

swissspidy
Copy link
Owner

See #78

@swissspidy swissspidy added the enhancement New feature or request label Sep 6, 2023
@swissspidy swissspidy added this to the 1.0.4 milestone Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #79 (59c0745) into main (71b6a89) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main      #79   +/-   ##
=========================================
  Coverage     92.21%   92.21%           
  Complexity      198      198           
=========================================
  Files             7        7           
  Lines           475      475           
=========================================
  Hits            438      438           
  Misses           37       37           
Flag Coverage Δ
default 92.21% <100.00%> (ø)
multisite 25.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/class-ginger-mo-translation-file-json.php 89.28% <100.00%> (ø)
lib/class-ginger-mo-translation-file-php.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@swissspidy swissspidy merged commit 077a9b1 into main Sep 6, 2023
24 checks passed
@swissspidy swissspidy deleted the fix-parsed-flag branch September 6, 2023 09:38
@swissspidy
Copy link
Owner Author

swissspidy commented Sep 6, 2023

Performance Test Results

Performance test results for 481ea5d are in 🛎️!

WordPress Admin

Locale Scenario wp-memory-usage wp-total
en_US Default 16.10 MB 176.55 ms
de_DE Default 32.72 MB 228.72 ms
de_DE Ginger MO (MO) 20.74 MB 207.39 ms
de_DE Ginger MO (PHP) 17.72 MB 181.05 ms
de_DE Ginger MO (JSON) 20.74 MB 195.33 ms

Twenty Twenty-Three

Locale Scenario wp-memory-usage wp-total
en_US Default 15.25 MB 151.93 ms
de_DE Default 28.69 MB 203.72 ms
de_DE Ginger MO (MO) 18.70 MB 180.80 ms
de_DE Ginger MO (PHP) 16.41 MB 157.97 ms
de_DE Ginger MO (JSON) 18.69 MB 174.24 ms

Twenty Twenty-One

Locale Scenario wp-memory-usage wp-total
en_US Default 14.78 MB 125.77 ms
de_DE Default 28.29 MB 177.53 ms
de_DE Ginger MO (MO) 18.24 MB 157.93 ms
de_DE Ginger MO (PHP) 15.94 MB 135.09 ms
de_DE Ginger MO (JSON) 18.24 MB 149.57 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant