Skip to content

Commit

Permalink
Applied code-review recommendations 2nd attempt
Browse files Browse the repository at this point in the history
  • Loading branch information
rommmka committed Apr 11, 2023
1 parent 4d733c1 commit c7fae80
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion Block/Adminhtml/Config/Form/Field/FixAll.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

class FixAll extends \Magento\Config\Block\System\Config\Form\Field
{

public function render(AbstractElement $element)
{
$url = $this->getUrl('swissup/theme/fixAll');
Expand Down
2 changes: 0 additions & 2 deletions etc/adminhtml/system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
</group>

<group id="troubleshooting" translate="label" type="text" sortOrder="260" showInDefault="1">
<label>Troubleshooting</label>
<field id="virtualcheck" translate="label" type="textarea" sortOrder="260" showInDefault="1" showInWebsite="0" showInStore="0">
Expand All @@ -29,7 +28,6 @@
<frontend_model>Swissup\Core\Block\Adminhtml\Config\Form\Field\FixAll</frontend_model>
</field>
</group>

</section>
</system>
</config>
4 changes: 1 addition & 3 deletions view/adminhtml/templates/config/field/virtual_check.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@

<h4>Virtual Theme Check</h4>

<?php
if (!$block->getVirtualThemes()->getSize()): ?>
<?php if (!$block->getVirtualThemes()->getSize()): ?>
<p style="color: green;">No virtual themes found. Check: passed!</p>
<?php else: ?>
<table>
Expand All @@ -32,5 +31,4 @@ if (!$block->getVirtualThemes()->getSize()): ?>
<?php endforeach; ?>
</tbody>
</table>

<?php endif; ?>

0 comments on commit c7fae80

Please sign in to comment.