Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension rejected from Marketplace #7

Closed
dimdimich opened this issue Oct 8, 2019 · 7 comments
Closed

Extension rejected from Marketplace #7

dimdimich opened this issue Oct 8, 2019 · 7 comments
Assignees

Comments

@dimdimich
Copy link
Contributor

Environment: PHP 7.0.31

Errors
Warnings

Errors : 1

Errors listed below must be fixed and resubmitted to Marketplace.
To prevent errors in the future please read our technical standards documentation.

File : /eqp-automation/temp/swissup/module-core/swissup-module-core-1.8.7/Model/Module/Installer.php
"require_once" statement detected. File manipulations are discouraged. Concatenating is forbidden. Variables inside are insecure.
severity : 10
Line : 205
Column : 9
Source : Magento2.Security.IncludeFile.FoundIncludeFile

@0m3r 0m3r changed the title Extension ejected from Marketplace Extension rejected from Marketplace Jan 16, 2020
@dimdimich
Copy link
Contributor Author

We still can't sumbit this module:

Errors : 1

Errors listed below must be fixed and resubmitted to Marketplace.
To prevent errors in the future please read our technical standards documentation.

File : /eqp-automation/temp/swissup/module-core/swissup-module-core-1.10.2/Model/Module/Installer.php
"require_once" statement detected. File manipulations are discouraged. Concatenating is forbidden. Variables inside are insecure.
severity : 10
Line : 205
Column : 9
Source : Magento2.Security.IncludeFile.FoundIncludeFile

@vovayatsyuk
Copy link
Member

We'll be able to do that after I'll update installation instructions for all modules and remove old installer from the module.

@dimdimich
Copy link
Contributor Author

Do you have any rough ETA?

@vovayatsyuk
Copy link
Member

Last week I've changed instructions for firecheckout. Waiting for a feedback.

@dimdimich
Copy link
Contributor Author

Can we work on this task sometime? It isn't urgent but just it would be great to have core module at marketplace.

@vovayatsyuk
Copy link
Member

@dimdimich
Copy link
Contributor Author

Thanks. Submitted and it's passed all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants