add an exit request hook type, allow to delay exit #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yellows8
reviewed
Oct 9, 2018
| @@ -1211,6 +1209,10 @@ bool appletMainLoop(void) { | |||
| } | |||
|
|
|||
| switch(msg) { | |||
| case 0x4: | |||
| appletCallHook(AppletHookType_OnExitRequest); | |||
| break; | |||
There was a problem hiding this comment.
Add: return false; here. Apps won't need to use appletHook with this, just use appletUnlockExit after main-loop exit. Apps should not exit without calling appletUnlockExit if appletLockExit was used.
There was a problem hiding this comment.
Also update your gist for this.
There was a problem hiding this comment.
true, that makes that use-case much simpler, I also updated the gist to reflect change
yellows8
approved these changes
Oct 9, 2018
|
Can you doc the lock/unlock cmds on switchbrew? https://switchbrew.org/wiki/AM_services#LockExit |
sure, will do i a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will permit to be able to be notified on exit by:
Here is an example of use: https://gist.github.com/p-sam/bd39c9a084cfd45c793d0bdfe2b8f2c7
Homebrew would be able to use this moment to flush state, and close handles. (eg: RetroArch flushing SaveRAM)