npdmtool: add content and save data owner parsing #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me. A quick question: does this PR result in all users of npdmtool needing to update their json files, or does it maintain compatibility with existing jsons? |
|
it will complain about missing content_owner/save_data_id_min/max similar to system_resource_size but generate identical npdm to the current version. |
yellows8
reviewed
Jun 5, 2020
yellows8
reviewed
Jun 5, 2020
yellows8
approved these changes
Jun 5, 2020
fincs
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://switchbrew.org/wiki/NPDM#FsAccessControl
I don't know how I could test Save data owner ids as fsOpenSaveDataFileSystemBySystemSaveDataId just opens all saves for me w/o setting it in the npdm