Improved watchSnapshot API (#169)

switcherapi · Apr 13, 2024 · ce86994 · ce86994
1 parent 590567a
commit ce86994
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/src/index.js b/src/index.js
@@ -114,20 +114,18 @@ export class Switcher {
     return Switcher.snapshot?.data.domain.version || 0;
   }
 
-  static watchSnapshot(success, error) {
+  static watchSnapshot(success = () => {}, error = () => {}) {
     if (Switcher.testEnabled || !Switcher.options.snapshotLocation?.length) {
-      return;
+      return error(new Error('Watch Snapshot cannot be used in test mode or without a snapshot location'));
     }
 
     const snapshotFile = `${Switcher.options.snapshotLocation}${Switcher.context.environment}.json`;
     watchFile(snapshotFile, () => {
       try {
         Switcher.snapshot = loadDomain(Switcher.options.snapshotLocation, Switcher.context.environment);
-        if (success)
-          success();
+        success();
       } catch (e) {
-        if (error)
-          error(e);
+        error(e);
       }
     });
   }

diff --git a/test/strategy-operations/network.test.js b/test/strategy-operations/network.test.js
@@ -24,6 +24,11 @@ describe('Processing strategy: NETWORK', () => {
         assert.isTrue(result);
     });
 
+    it('should agree when input range EXIST - Irregular CIDR', async function () {
+        const result = await processOperation(StrategiesType.NETWORK, OperationsType.EXIST, '10.0.0.3', ['10.0.0.3/24']);
+        assert.isTrue(result);
+    });
+
     it('should NOT agree when input range DOES NOT EXIST', async () => {
         const result = await processOperation(
             StrategiesType.NETWORK, OperationsType.EXIST, '10.0.0.4', mock_values1);

diff --git a/test/switcher-watch-snapshot.test.js b/test/switcher-watch-snapshot.test.js
@@ -106,4 +106,17 @@ describe('E2E test - Switcher local - Watch Snapshot:', function () {
     }
   });
 
+  it('should NOT allow to watch snapshot - Switcher test is enabled', function (done) {
+    Switcher.setTestEnabled();
+
+    let errorMessage;
+    Switcher.watchSnapshot(undefined, (err) => {
+      errorMessage = err.message;
+    });
+
+    assert.equal(errorMessage, 'Watch Snapshot cannot be used in test mode or without a snapshot location');
+    done();
+    Switcher.setTestDisabled();
+  });
+
 });