Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard design #72

Merged
merged 26 commits into from
Aug 13, 2023
Merged

Dashboard design #72

merged 26 commits into from
Aug 13, 2023

Conversation

Zeeshnhmd
Copy link
Contributor

route name to access the design /dashboard1 its unprotected.

@dev-bre
Copy link
Contributor

dev-bre commented Aug 13, 2023

Thanks @Zeeshnhmd a couple of things:

  • Please change the file Dashboard.tsx instead of adding Dashboard1.tsx.
  • no need for AuthLayout.tsx, there is already a DashboardLayout you can change
  • I see your sidebar have links not related to what switchfeat does, please integrate with existing links
  • for the 3 cards, can you please have them related to what switchfeat does? Like Segments, Flags, Rules?

@Zeeshnhmd
Copy link
Contributor Author

Hey, @dev-bre

  • for point 3 please elaborate more or give me a list of the link you want to add and their names.
  • for point 4 please provide a sketch.

@Zeeshnhmd
Copy link
Contributor Author

Zeeshnhmd commented Aug 13, 2023

@dev-bre pushed the new changes have a look except for the point 4 changes you need to provide me a sketch for this.

packages/ui/src/layout/DashboardLayout.tsx Show resolved Hide resolved
packages/ui/src/App.tsx Outdated Show resolved Hide resolved
@Zeeshnhmd
Copy link
Contributor Author

Conversation resolved have a look now

@dev-bre dev-bre merged commit 2d3f189 into switchfeat-com:main Aug 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants