Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Jellyfin not installing correctly #1032
base: develop
Are you sure you want to change the base?
Fix Jellyfin not installing correctly #1032
Changes from 21 commits
1d7b4da
a3e7477
1d3e3f2
bbe6273
cacdb90
a0a231c
43b7a57
fade94a
94ddc93
1ecbff5
870fc5f
cc216ec
89a5568
799c871
41d641e
6f83dd6
bdf19c9
2404dae
2678a36
b70e6e8
4d83319
1b2839e
fb90ac2
7f73a11
2b25b27
de9d67b
4be6eee
f746309
83b0a17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is basically useless aside from setting the _os_codename. If an OS doesn't directly identify itself as Debian or Ubuntu (i.e. during install) then we don't support it.
We certainly don't support linux mint or kde neon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was unaware we don’t support those distros at all. I will be removing them from the scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed unsupported distros, but I am not aware if _os_codename is set as debian on raspbian. It is necessary to make sure raspbian is set to the same repos as debian, as that is what Jellyfin requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gnupg2 is a global dependency of swizzin. You can safely assume every user has this installed already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replicated code should be a function; however, this is useless code beyond the setting of the distro codename (as above)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will use _os_codename in both cases if you can confirm that raspbian is set to debian. If not, I will create a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replicated code should be functionized (sources/functions/jellyfin), however I wouldn't block merging based on this, but it would be best-practices for long-term ease of maintenace.