Build warnings in swoole.c #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o_print_table_start' [-Wimplicit-function-declaration]
…arg in call (detected thanks to added proto)
…e CHECK default value
… dropping unneed code, please Check
…ialized] - Please CHECK
…his function [-Wmaybe-uninitialized] - Please review Logic
…makes integer from pointer without a cast - Please check
…nt', but argument 5 has type 'long int' [-Wformat=]
… from incompatible pointer type [enabled by default]
=> expected 'void * (*)(void *)
Please review this change.
From man:
* It calls pthread_exit(3), specifying an exit status value that is available to another thread in the same process that calls pthread_join(3).
* It returns from start_routine(). This is equivalent to calling pthread_exit(3) with the value supplied in the return statement.
So the return NULL, seems enough.
As the serv option is not used, having void * seems ok.
|
This is my last one. With all this changes, the build is "warning free" (Using -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector ) Some commit need to be checked. |
matyhtf
added a commit
that referenced
this pull request
Dec 26, 2013
|
Good.. |
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previous, some are only cosmetic.
The missing swProcessPool_dispatch proto hide a bad call.
Please review 6a68dfb and f24c413