Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync-client async connect bugs #4152

Merged
merged 3 commits into from
Apr 12, 2021
Merged

fix sync-client async connect bugs #4152

merged 3 commits into from
Apr 12, 2021

Conversation

matyhtf
Copy link
Member

@matyhtf matyhtf commented Apr 12, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #4152 (4178a21) into master (b3883ea) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4152      +/-   ##
==========================================
+ Coverage   48.74%   48.78%   +0.04%     
==========================================
  Files          71       71              
  Lines       14280    14282       +2     
==========================================
+ Hits         6961     6968       +7     
+ Misses       7319     7314       -5     
Impacted Files Coverage Δ
src/network/client.cc 47.09% <44.44%> (+0.52%) ⬆️
src/network/dns.cc 86.75% <100.00%> (+0.06%) ⬆️
src/os/async_thread.cc 68.85% <0.00%> (-0.44%) ⬇️
src/server/manager.cc 30.88% <0.00%> (ø)
src/protocol/base.cc 63.15% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c85b2b...4178a21. Read the comment docs.

@matyhtf matyhtf merged commit 12aa64c into master Apr 12, 2021
@matyhtf matyhtf deleted the fix-client-async-connect branch April 12, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant