get rid of inet_ntoa and inet_aton calls #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
commented
May 11, 2021
| add_assoc_string(return_value, "host", tmp); | ||
| } else { | ||
| php_swoole_fatal_error(E_WARNING, "inet_ntop() failed"); | ||
| } |
There was a problem hiding this comment.
same / consistent behavior than the below one for IPv6
|
Notice: in php-src new call usage are conditional (#ifdef HAVE_NET...) but are already used in swoole without such condition |
Codecov Report
@@ Coverage Diff @@
## master #4199 +/- ##
==========================================
+ Coverage 50.11% 50.15% +0.03%
==========================================
Files 71 71
Lines 14266 14267 +1
==========================================
+ Hits 7149 7155 +6
+ Misses 7117 7112 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions are deprecated and may be forbidden in some distro.
Already erraticated in php-src
third-party file seems a copy paste from ph-src, perhaps need a full refresh