Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert_emails_sent #757

Merged
merged 6 commits into from
Apr 22, 2023
Merged

Add assert_emails_sent #757

merged 6 commits into from
Apr 22, 2023

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Apr 7, 2023 •
edited

This PR adds the assert_emails_sent function (#560 ).

Proposed changes

  • add a function to make it easier to test deliver_many

@geeksilva97 geeksilva97 changed the title add assert_emails_sent Add assert_emails_sent Apr 7, 2023
@geeksilva97 geeksilva97 marked this pull request as ready for review April 7, 2023 05:03
princemaple
princemaple requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@princemaple princemaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general :) Thanks heaps for the PR

lib/swoosh/test_assertions.ex Outdated Show resolved Hide resolved
lib/swoosh/test_assertions.ex Outdated Show resolved Hide resolved
@princemaple princemaple merged commit de8fbf1 into swoosh:main Apr 22, 2023
10 checks passed
@princemaple
Copy link
Member

💜

@princemaple princemaple mentioned this pull request May 27, 2023
Merged
@geeksilva97
Copy link
Contributor Author

Looks good in general :) Thanks heaps for the PR

No prob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princemaple princemaple princemaple requested changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@geeksilva97 @princemaple