Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for makeStyles #160

Open
Plawn opened this issue Dec 20, 2022 · 2 comments
Open

Add support for makeStyles #160

Plawn opened this issue Dec 20, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@Plawn
Copy link

Plawn commented Dec 20, 2022

makeStyle is a great way to separate the css in js from the rest of the logic and I find it easier to use than sx

tss-react makes it possible to use it as per mui documentation, could it be possible to add the same for suid ?

https://mui.com/material-ui/guides/interoperability/#jss-tss

@juanrgm juanrgm added the enhancement New feature or request label Dec 22, 2022
@Bersaelor
Copy link

Bersaelor commented Feb 13, 2023

Didn't mui stop supporting makeStyles in favor of styled()?

I've been migrating one of our React codebases from makeStyles to styled() and have not looked back since.

@Plawn
Copy link
Author

Plawn commented Feb 14, 2023

I think it's a matter of taste, you are right they wanted to ditch the support for makeStyles in favor of styled
But some of us, do prefer the makeStyles approah as per: this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants