Implement reading from rosbag2 files #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've implemented reading from rosbag2 files. I've used `rosbag2_transport::ReaderWriterFactory` so that both compressed and uncompressed bagfiles can be handled.
|
I'll take a deeper look, but it looked good at first glance. Thanks so much for this! |
|
Any update here? I'm missing this feature a lot, would be great if this could be merged and released! |
danthony06
approved these changes
Jun 20, 2024
|
Working on blooming this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented reading from rosbag2 files. I've used
rosbag2_transport::ReaderWriterFactoryso that both compressed and uncompressed bagfiles can be handled.