Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch and Verification Point Feature #18

Open
marip8 opened this issue Feb 14, 2020 · 3 comments
Open

Touch and Verification Point Feature #18

marip8 opened this issue Feb 14, 2020 · 3 comments

Comments

@marip8
Copy link
Collaborator

marip8 commented Feb 14, 2020

The current offline planning GUI prompts the user to specify some number of touch and verification points for a mesh. These were initially intended to be used to verify the localization of the part during operation of the robot. #16 touches on whether or not these features should be included.

It seems like we have some options for resolving this issue:

  1. Keep the approach in Remove the requirement for 3 touch points #16 and make the minimum number of each type of point configurable
  2. Remove the touch and verification point feature. It may be too application-specific and unrelated to generating tool paths offline
  3. Retain it as a feature, remove it from the nominal offline planning GUI, and create a separate GUI for it (perhaps one that can be added as a plugin to the nominal planning GUI)

@mpowelson @DavidMerzJr any thoughts?

@mpowelson
Copy link
Contributor

mpowelson commented Feb 14, 2020

I think touch points are a premium feature that require a monthly subscription. I'd remove them completely.

@marip8
Copy link
Collaborator Author

marip8 commented Feb 14, 2020

I think I am in the camp of removing the concepts of touch and verification points. However, I think the ability to click on the surface and generate discrete points (whose transform values are still editable by a user) is probably a valuable thing to keep around. Maybe option 4 is to re-brand the touch/verification point features as a general discrete point generator

@gavanderhoorn
Copy link

However, I think the ability to click on the surface and generate discrete points (whose transform values are still editable by a user) is probably a valuable thing to keep around. Maybe option 4 is to re-brand the touch/verification point features as a general discrete point generator

I'm only an outsider, but I would very much support the idea of keeping that functionality around.

Being able to select/pick points / polygons on a surface is a very nice feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants