Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix form submissions #36

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix form submissions #36

merged 1 commit into from
Nov 4, 2022

Conversation

codedmonkey
Copy link
Contributor

Description

Fixes an issue when submitting a form.

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

@daun
Copy link
Member

daun commented Nov 2, 2022

Good catch :) Could you run npm run build to build the dist files and push those changes as well?

@codedmonkey
Copy link
Contributor Author

Done :)

Note that installing the dependencies in Node v18 seems to be broken

@daun daun merged commit 520db9d into swup:master Nov 4, 2022
@daun
Copy link
Member

daun commented Nov 4, 2022

Thanks! Will tag a release and check out the node 18 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daun daun daun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codedmonkey @daun