Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to cli for bundling #60

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Switch to cli for bundling #60

merged 3 commits into from
Sep 19, 2023

Conversation

daun
Copy link
Member

@daun daun commented Sep 19, 2023 •
edited
Loading

Description

  • Switch to @swup/cli for bundling
  • Correctly separate dependencies from dev dependencies
  • Includes version bump and changelog update

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • The documentation was updated as required

hirasso
hirasso approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we release and test this before doing all the other plugins?

@daun
Copy link
Member Author

daun commented Sep 19, 2023

@hirasso That was the plan! It's building fine locally, but let's see about CI 😱

@daun daun merged commit bd1c93a into master Sep 19, 2023
@daun daun deleted the cli branch September 19, 2023 20:48
@daun
Copy link
Member Author

daun commented Sep 19, 2023

@hirasso Publishes on CI and works when npm-installed in a project ✅

@hirasso
Copy link
Member

hirasso commented Sep 20, 2023

Amazing 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirasso hirasso hirasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daun @hirasso