Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visit object accessor #17

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix visit object accessor #17

merged 2 commits into from
Jul 29, 2023

Conversation

daun
Copy link
Member

@daun daun commented Jul 29, 2023

Description

  • Fix accessor to old context object, recently renamed visit

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

Closes #16

@daun daun requested a review from a team July 29, 2023 18:21
@daun daun mentioned this pull request Jul 29, 2023
Closed
3 tasks
@daun daun merged commit 4cd73c7 into master Jul 29, 2023
@daun daun deleted the fix-visit-object branch July 29, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirasso hirasso hirasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot integrate Gia Plugin with swup 4.1
2 participants
@daun @hirasso