Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx manager still spawns duplicate Sphinx agents on server restart with multiple projects open #660

Closed
alcarney opened this issue Oct 11, 2023 · 0 comments · Fixed by #744
Labels
bug Something isn't working lsp Issues that relate to the language server
Milestone

Comments

@alcarney
Copy link
Member

The current fix has calls to get_client() wait on an asyncio.Task that is in the process of creating a new client.

This works well when a single project is open, however when a client is bulk-opening documents spanning multiple projects it's not sufficient. This is due to the client being created is only relevant for some of the documents, once the client has been created multiple documents are free to start the process of creating their own clients - leading to duplicates

@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server labels Oct 11, 2023
@alcarney alcarney added this to the 1.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp Issues that relate to the language server
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant