Preview improvements #793
Merged
Preview improvements #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following a similar pattern to the `SphinxClient`, we can make the `WebviewServer` awaitable and accept its configuration in the init method. This then makes it easy to teardown and recreate "in the background" when the configuration is changed, with code that requires it automatically restarting the server by awaiting it.
Following a similar pattern to the `SphinxClient`, we can make the `PreviewServer` awaitable and accept its configuration in the init method. This then makes it easy to teardown and recreate "in the background" when the configuration is changed, with code that requires it automatically restarting the server by awaiting it.
As well as being closer to the LSP specification, this allows the server to request the client change the document that is being shown - such as when the server port has been changed.
This allows the extension to intercept `window/showDocument` requests and update the preview pane accordingly
That way changes to options like `showLineMarkers` also reload the webview
Whereas the reStructuredText part of the extension could copy the patterns for previews established by VSCode's markdown support, doing so for markdown files would (surprise, surprise!) create conflicts. So, the toolbar button and command names have been "re-branded" to make them distinct from the built-in markdown ones. The reStructuredText part of the extension keeps its existing keybindings (for now?) and no keybindings have been set for the markdown side. Open for suggestions as to what a good default keybinding could be :) Ref: swyddfa#780
alcarney
force-pushed
the
preview-improvements
branch
from
201bdf5
to
f97e11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains a collection of improvements to previews in both the language server and the VSCode extension
esbonio.preview.*optionswindow/showDocumentrequests when previewing a file