Merge pull request #4712 from nilsvu/xcts_wrap_hydro

Extend Xcts::WrappedGr to GRMHD
sxs-collaboration · Feb 20, 2023 · 8d29566 · 8d29566
2 parents afb9518 + 08a2875
commit 8d29566
Show file tree

Hide file tree

Showing 13 changed files with 466 additions and 94 deletions.
diff --git a/docs/References.bib b/docs/References.bib
@@ -2062,6 +2062,23 @@ @article{Szilagyi2014fna
     year = "2014"
 }
 
+@article{Tacik2016zal,
+  author        = {Tacik, Nick and Foucart, Francois and Pfeiffer, Harald P.
+                   and Muhlberger, Curran and Kidder, Lawrence E. and Scheel,
+                   Mark A. and Szil\'agyi, B.},
+  title         = {Initial data for black hole-neutron star binaries, with
+                   rotating stars},
+  eprint        = {1607.07962},
+  archiveprefix = {arXiv},
+  primaryclass  = {gr-qc},
+  doi           = {10.1088/0264-9381/33/22/225012},
+  journal       = {Class. Quant. Grav.},
+  volume        = {33},
+  number        = {22},
+  pages         = {225012},
+  year          = {2016}
+}
+
 @article{Teukolsky2015ega,
   author         = "Teukolsky, Saul A.",
   title          = "Formulation of discontinuous {Galerkin} methods for

diff --git a/src/PointwiseFunctions/AnalyticSolutions/RelativisticEuler/RotatingStar.hpp b/src/PointwiseFunctions/AnalyticSolutions/RelativisticEuler/RotatingStar.hpp
@@ -413,6 +413,10 @@ class RotatingStar : public virtual evolution::initial_data::InitialData,
     return equation_of_state_;
   }
 
+  double equatorial_radius() const {
+    return cst_solution_.equatorial_radius();
+  }
+
  protected:
   template <typename DataType>
   using DerivLapse = ::Tags::deriv<gr::Tags::Lapse<DataType>, tmpl::size_t<3>,

diff --git a/src/PointwiseFunctions/AnalyticSolutions/Xcts/CMakeLists.txt b/src/PointwiseFunctions/AnalyticSolutions/Xcts/CMakeLists.txt
@@ -37,6 +37,7 @@ target_link_libraries(
   ErrorHandling
   GeneralRelativity
   GeneralRelativitySolutions
+  GrMhdAnalyticData
   InitialDataUtilities
   Options
   Parallel

diff --git a/src/PointwiseFunctions/AnalyticSolutions/Xcts/Factory.hpp b/src/PointwiseFunctions/AnalyticSolutions/Xcts/Factory.hpp
@@ -3,9 +3,12 @@
 
 #pragma once
 
+#include "PointwiseFunctions/AnalyticData/GrMhd/CcsnCollapse.hpp"
+#include "PointwiseFunctions/AnalyticData/GrMhd/MagnetizedTovStar.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/GeneralRelativity/HarmonicSchwarzschild.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/GeneralRelativity/KerrSchild.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/GeneralRelativity/SphericalKerrSchild.hpp"
+#include "PointwiseFunctions/AnalyticSolutions/RelativisticEuler/RotatingStar.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/Xcts/Flatness.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/Xcts/Schwarzschild.hpp"
 #include "PointwiseFunctions/AnalyticSolutions/Xcts/TovStar.hpp"
@@ -18,6 +21,15 @@ namespace Solutions {
 using all_analytic_solutions =
     tmpl::list<Flatness, WrappedGr<gr::Solutions::KerrSchild>,
                WrappedGr<gr::Solutions::SphericalKerrSchild>, Schwarzschild,
-               WrappedGr<gr::Solutions::HarmonicSchwarzschild>, TovStar>;
+               WrappedGr<gr::Solutions::HarmonicSchwarzschild>, TovStar,
+               WrappedGrMhd<RelativisticEuler::Solutions::RotatingStar>,
+               // The following are only approximate solutions to the XCTS
+               // equations. We list them here (as opposed to AnalyticData) to
+               // avoid a cyclic dependency with the `WrappedGr` class, and also
+               // for convenience: by treating them as analytic solutions we can
+               // easily measure the difference between the approximate
+               // (analytic) solution and the numerical solution.
+               WrappedGrMhd<grmhd::AnalyticData::CcsnCollapse>,
+               WrappedGrMhd<grmhd::AnalyticData::MagnetizedTovStar>>;
 }  // namespace Solutions
 }  // namespace Xcts
diff --git a/src/PointwiseFunctions/AnalyticSolutions/Xcts/TovStar.hpp b/src/PointwiseFunctions/AnalyticSolutions/Xcts/TovStar.hpp
@@ -188,7 +188,6 @@ class TovStar : public elliptic::analytic_data::AnalyticSolution {
   TovStar& operator=(TovStar&&) = default;
   ~TovStar() = default;
 
-  template <typename... OptionTypes>
   TovStar(double central_rest_mass_density,
           std::unique_ptr<EquationsOfState::EquationOfState<true, 1>>
               equation_of_state,