Add support for ComplexDataVector to Pypp tests #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moxcodes
force-pushed
the
pypp_complex
branch
3 times, most recently
from
fe1c346
to
c4f9c46
Compare
moxcodes
added a commit
to moxcodes/spectre
that referenced
this pull request
Feb 26, 2019
nilsdeppe
previously approved these changes
Feb 26, 2019
osheamonn
previously approved these changes
Feb 26, 2019
moxcodes
force-pushed
the
pypp_complex
branch
from
c4f9c46
to
76b5fe5
Compare
|
squashed in iwyu and clang-tidy changes to make Travis happy. |
nilsdeppe
reviewed
Feb 26, 2019
| @@ -143,7 +143,7 @@ void check_with_random_values_impl( | |||
| std::index_sequence<ResultIs...> /*index_return_types*/, | |||
| std::index_sequence<ArgumentIs...> /*index_argument_types*/, | |||
| std::index_sequence<MemberArgsIs...> /*index_member_args*/, | |||
| TagsList /*meta*/, const double epsilon = 1.0e-12) { | |||
| TagsList /*meta*/, double epsilon = 1.0e-12) { | |||
There was a problem hiding this comment.
this is fixed more correctly in #1389 so my vote is let's ignore it :) clang-tidy is wrong here
There was a problem hiding this comment.
Alright, sounds good. Removed.
moxcodes
force-pushed
the
pypp_complex
branch
from
76b5fe5
to
0008d67
Compare
moxcodes
force-pushed
the
pypp_complex
branch
from
0008d67
to
cee1036
Compare
nilsdeppe
approved these changes
Feb 26, 2019
osheamonn
approved these changes
Feb 27, 2019
|
clang-tidy failure is false positive address in #1389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Python (and numpy) routines gracefully handle complex values, so it's just a matter of bringing the values from the
ComplexDataVectorover to the numpy structures.Types of changes:
Component:
Code review checklist
clang-tidyandIWYU.For instructions on how to perform the CI checks locally refer to the Dev
guide on the Travis CI.
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.