-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCE-GH executable #2323
CCE-GH executable #2323
Conversation
d7864f9
to
475a30a
Compare
The CI failure here is most likely due to running out of memory on the github CI virtual machines, so this PR will have to wait until the |
Would anyone object to squashing this one? |
832b213
to
f6e6436
Compare
Could you please fix the conflicts? |
f6e6436
to
15889b5
Compare
rebased on develop, fixed all the conflicts. |
15889b5
to
c0ac523
Compare
Rebased on develop and fixed conflicts |
c0ac523
to
9c4ad95
Compare
2848720
to
1b4c1a5
Compare
Now dependent on #2555, but the good news is that the optimizations in that PR are enough to get CI to run to completion on this one. |
1b4c1a5
to
0155e88
Compare
Rebased on develop, no longer dependent. |
@geoffrey4444 @markscheel please look at |
@geoffrey4444 @markscheel please look at @moxcodes this needs a rebase |
0155e88
to
8aae0ae
Compare
cb3242e
to
727ad4c
Compare
727ad4c
to
a2eee34
Compare
I've updated this now, and added a handful of commits that were necessary to fix changes in the interface logic from time stepping and interpolator changes. The new commits are:
I'm happy to split some of these smaller preparatory commits out into a separate PR if that would be easier for the reviewers -- I just thought I'd put them here to begin with, because they are all related to making the CCE system work in tandem with GH. |
a2eee34
to
8ae08f7
Compare
18f176f
to
c12961a
Compare
- previous alterations only fixed one of the function overloads, causing inconsistent target points during some executions.
The `receive_data` calls appropriately restart the algorithm execution. This change allows phase changes from quiescence detection due to inactivity (i.e. no more data being supplied by the GH elements); without terminating at the stage in which the component waits for data, the Algorithm generates an error if a phase change occurs while the CCE component is inactive. We want to permit such phase changes, because the CCE component is in a safe state for balancing or checkpointing when it is inactive and waiting for data.
This is already implicitly assumed because we explicitly invoke `ChangeStepSize` during CCE evolution.
c12961a
to
e9b323a
Compare
On the plus side, due to the new dense output features, the CCE-GH executable will now support local time-stepping, and independently varies the step size. |
@knelli2 can this PR be closed or is there still something we haven't implemented yet? |
We have a GH+CCE executable now. We don't have a BBH+CCE executable yet, but it's unclear if we actually want that (except maybe for CCM). And that would be a whole separate PR anyways. So I'll go ahead and close this PR. |
Proposed changes
Add the combined GH-CCE executable. This also refactors the GH executable into a 'base' metavariables to avoid code duplication as much as possible.
Types of changes:
Component:
Code review checklist
clang-tidy
.For instructions on how to perform the CI checks locally refer to the Dev
guide on the Travis CI.
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
Dependencies
temporal_id
for interpolation in interpolation target tags #3421