Fix PiecewisePolytropicFluid Python test, add some bindings #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajkosmi
reviewed
Feb 2, 2023
| @@ -1,19 +1,27 @@ | |||
| # Distributed under the MIT License. | |||
| # See LICENSE.txt for details. | |||
|
|
|||
| import spectre.PointwiseFunctions.Hydro.EquationsOfState as spectre_eos | |||
|
|
|||
| import unittest | |||
There was a problem hiding this comment.
@nilsvu are the imports required to be alphabetized in .py files, or is that just with #include in .cpp/.hpp files? If not, then everything looks good to me.
There was a problem hiding this comment.
We haven't established a rule for sorting imports yet. I started to use isort recently, which puts system modules before third-party modules, then alphabetizes.
pajkosmi
previously approved these changes
Feb 2, 2023
knelli2
requested changes
Feb 2, 2023
Comment on lines
7
to
8
| #include "PointwiseFunctions/Hydro/EquationsOfState/Python/PiecewisePolytropicFluid.hpp" | ||
| #include "PointwiseFunctions/Hydro/EquationsOfState/Python/PolytropicFluid.hpp" |
There was a problem hiding this comment.
[Commit message]
This isn't a PiecewisePolynomial it's a PiecewisePolytrope
nilsvu
changed the title
We can do this now that we have Tensor bindings.
nilsvu
force-pushed
the
fix_test_label
branch
from
cf39bc9
to
67d490f
Compare
knelli2
approved these changes
Feb 4, 2023
nilsdeppe
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #4523. I also added some bindings while I was touching the files.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments