Add Single horizon measurement #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
force-pushed
the
single_horizon_measurement
branch
from
2c75489
to
03666b0
Compare
nilsdeppe
requested changes
Feb 15, 2023
|
|
||
| namespace control_system::measurements { | ||
| template <::domain::ObjectLabel Horizon> | ||
| struct SingleHorizon : tt::ConformsTo<protocols::Measurement> { |
There was a problem hiding this comment.
Add some dox just so it shows up?
wthrowe
reviewed
Feb 15, 2023
| namespace control_system::measurements { | ||
| template <::domain::ObjectLabel Horizon> | ||
| struct SingleHorizon : tt::ConformsTo<protocols::Measurement> { | ||
| struct SubMeasurement : tt::ConformsTo<protocols::Submeasurement> { |
There was a problem hiding this comment.
[optional] Your capitalization here is kind of weird.
knelli2
force-pushed
the
single_horizon_measurement
branch
from
03666b0
to
3a2f915
Compare
|
Squashed both of the changes and also added some docs to the |
nilsdeppe
approved these changes
Feb 15, 2023
wthrowe
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
And use it in the shape control system. This is similar to the BothHorizons measurement, except it is only for one horizon.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
Depends on and includes #4728.