Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell centered flux tags #4738

Merged
merged 4 commits into from Feb 27, 2023
Merged

Cell centered flux tags #4738

merged 4 commits into from Feb 27, 2023

Conversation

nilsdeppe
Copy link
Member

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

kidder
kidder requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can squash

src/Evolution/DgSubcell/Tags/CellCenteredFlux.hpp Outdated
/// despite going to high-order, with no additional FLOP overhead. We do,
/// however, have the memory overhead of the cell-centered fluxes.
///
/// \note The `TagsList` is a list of the variables, not the fluxes. Tphey are
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They

@nilsdeppe
Copy link
Member Author

Done, rebased, squashed. Thanks for the review!

@kidder kidder added the auto-merge GitHub's auto-merge has been enabled for this PR. label Feb 27, 2023
@kidder kidder merged commit 4765d63 into sxs-collaboration:develop Feb 27, 2023
@nilsdeppe nilsdeppe deleted the cell_centered_flux_tags branch September 14, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidder kidder kidder approved these changes

Assignees
No one assigned
Labels
auto-merge GitHub's auto-merge has been enabled for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nilsdeppe @kidder