Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Find NumPy with CMake's built-in FindPython" #4740

Merged
merged 2 commits into from Feb 16, 2023
Merged

Revert "Find NumPy with CMake's built-in FindPython" #4740

merged 2 commits into from Feb 16, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 16, 2023

Proposed changes

Reverts part of #4731 because it led to build issues on Wheeler. Turns out CMake's built-in code to find NumPy isn't as great as I hoped it would be.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from knelli2 February 16, 2023 04:21
@nilsvu nilsvu added the bugfix label Feb 16, 2023
knelli2
knelli2 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can configure with this on Wheeler now.

@knelli2 knelli2 added the priority critical for progress label Feb 16, 2023
@nilsdeppe nilsdeppe merged commit fa1842d into sxs-collaboration:develop Feb 16, 2023
@nilsvu nilsvu deleted the fix_numpy branch February 16, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsdeppe nilsdeppe nilsdeppe approved these changes

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
bugfix priority critical for progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilsvu @nilsdeppe @knelli2