Unify naming pattern of excision spheres #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most other things have the convention ThingLabel, but the excision
spheres were named ObjectLabelThing. This changes all occurrences
of Object{A,B}ExcisionSphere to ExcisionSphere{A,B} and
CentralExcisionSphere to just ExcisionSphere
3 tasks
wthrowe
approved these changes
Feb 16, 2023
nilsvu
reviewed
Feb 16, 2023
| @@ -510,7 +510,7 @@ Domain<3> BinaryCompactObject::create_domain() const { | |||
| std::unordered_map<std::string, ExcisionSphere<3>> excision_spheres{}; | |||
| if (object_A_.is_excised()) { | |||
| excision_spheres.emplace( | |||
| "ObjectAExcisionSphere", | |||
| "ExcisionSphereA", | |||
There was a problem hiding this comment.
Maybe replace all these hardcoded names with get_output(label)? It's easier to regex-replace domain::ObjectLabel::A than literal single-character As :)
There was a problem hiding this comment.
I was going to do a separate PR where I used the ObjectLabel for the names in the BBH domains (excision spheres and functions of time). Does that sound ok?
nilsvu
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Most other things have the convention ThingLabel, but the excision spheres were named ObjectLabelThing. This changes all occurrences of Object{A,B}ExcisionSphere to ExcisionSphere{A,B} and CentralExcisionSphere to just ExcisionSphere
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments