Add worldtube boundary conditions to CSW #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwit
force-pushed
the
worldtube-BCs
branch
from
ba89347
to
c09a27a
Compare
nikwit
force-pushed
the
worldtube-BCs
branch
from
c09a27a
to
2e5a891
Compare
nilsdeppe
previously approved these changes
Feb 24, 2023
| * It is then treated like a ghost field and applied with the chosen numerical | ||
| * flux. So far only the upwind flux has been tried. | ||
| * | ||
| * We tried several other combinations such as setting all fields from the |
There was a problem hiding this comment.
These are really great things to have in the documentation. Thank you for adding them!
|
Looks like this needs a rebase to resolve a conflict. Can you ping me once that's done and we can merge this? |
nikwit
force-pushed
the
worldtube-BCs
branch
from
2e5a891
to
46028a9
Compare
|
@nilsdeppe thank you for your review! I have rebased it. |
nilsdeppe
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds the boundary conditions through which the worldtube communicates with the neighboring elements. They are a combination of constraint preserving boundary conditions and the analytical worldtube solution.
depends on #4752