Speed up BBH domain tests #4755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for fuzzy testing a large number of option combinations.
nilsvu
force-pushed
the
test_bbh_domain
branch
from
3dfb302
to
d25b5e3
Compare
nilsvu
force-pushed
the
test_bbh_domain
branch
from
d25b5e3
to
942db4f
Compare
nilsdeppe
approved these changes
Feb 21, 2023
| * \brief A random element between `start` and `end` | ||
| */ | ||
| template <typename Iter> | ||
| Iter random_sample(Iter start, Iter end, |
There was a problem hiding this comment.
This seems pretty generic, maybe move to Utilities/RandomSample.hpp?
There was a problem hiding this comment.
I can't think of a use case outside of tests right now, so I suggest we keep it in tests/ for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
These test have been timing out repeatedly. Instead of testing all possible combinations of options, this PR switches to fuzzy testing, as started in #4697.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments