Refactor Render1D #4757
Merged
Refactor Render1D #4757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
force-pushed
the
py_cli_vis
branch
5 times, most recently
from
d899296
to
d589b88
Compare
Also bind equality operator and add a test.
- Plot Lagrange interpolation in each DG element - Optionally plot collocation points, element boundaries, basis polynomials - Plot multiple variables (e.g. field and TCI status) - Set plot style with a stylesheet if needed.
nilsvu
added
the
new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I've been using this to debug the elliptic DG operator at large outer radii in 1D. I added a bunch of new features to the Render1D script so it can produce plots like this now, including collocation points, element boundaries, Lagrange interpolation, and individual basis polynomials:
Here's another example animating a Burgers evolution with subcell:
burgers.mp4
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments