Write an H5::Cce file from the *CharacteristicExtract execs #5985
Conversation
knelli2
added
the
in progress
|
Note that I still need to update the CCE tutorial docs |
knelli2
removed
the
in progress
|
|
||
| const std::string subfile_name{"Cce"}; |
There was a problem hiding this comment.
Is this what we want to name the subfile? This produces output in the H5 file like
/Cce.cce Group
/Cce.cce/EthInertialRetardedTime Dataset {26451/Inf, 163}
/Cce.cce/News Dataset {26451/Inf, 163}
/Cce.cce/Psi0 Dataset {26451/Inf, 163}
/Cce.cce/Psi1 Dataset {26451/Inf, 163}
/Cce.cce/Psi2 Dataset {26451/Inf, 163}
/Cce.cce/Psi3 Dataset {26451/Inf, 163}
/Cce.cce/Psi4 Dataset {26451/Inf, 163}
/Cce.cce/Strain Dataset {26451/Inf, 163}
/src.tar.gz Dataset {7757329}
which seems a bit redundant? Other options could be /Bondi.cce, /Scri.cce, /FutureNullInfinity.cce, /SpECTRE.cce.
There was a problem hiding this comment.
I agree. I think any are fine, except maybe Bondi to avoid confusion with the BondiSachs worldtube data we write out from GH that's input into CCE? Another option could be to append the worldtube radius? E.g. SpectreR100.cce in case we do want to run multiple CCE's simultaneously in the future.
|
|
||
| const std::string subfile_name{"Cce"}; |
There was a problem hiding this comment.
I agree. I think any are fine, except maybe Bondi to avoid confusion with the BondiSachs worldtube data we write out from GH that's input into CCE? Another option could be to append the worldtube radius? E.g. SpectreR100.cce in case we do want to run multiple CCE's simultaneously in the future.
knelli2
force-pushed
the
h5_cce_action
branch
2 times, most recently
from
bbdbcd5
to
0cafb3e
Compare
|
@nilsdeppe Rebased and squashed in existing fixups. Added one new commit that adds the extraction radius to the global cache for CCE execs because it wasn't there before, and then another fixup that changes the subfile name to |
| #include <string> | ||
|
|
||
| namespace Cce { | ||
| // retrieves the extraction radius from the specified file. |
There was a problem hiding this comment.
Add another slash to make these Doxygen comments?
And maybe group together with next one?
| ERROR( | ||
| "The CCE filename must encode the extraction radius as an integer " | ||
| "between the first instance of 'R' and the first instance of '.' " | ||
| "(SpEC " |
There was a problem hiding this comment.
[optional] Combine with next line?
Writes data to an h5::Cce subfile
Proposed changes
Instead of writing a bunch of
.datfiles in the H5 file for each Bondi quantity at future null infinity,CharacteristicExtractandKleinGordonCharacteristicExtractnow output anH5::Ccesubfile. See #5963 for more details about the subfile.Upgrade instructions
The output from CCE in the reductions file should only be a
Cce.ccesubfile. It won't have a bunch of.datfiles anymore.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments