Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LVC integration #89

Merged
merged 52 commits into from
May 15, 2024
Merged

Add LVC integration #89

merged 52 commits into from
May 15, 2024

Conversation

moble
Copy link
Member

@moble moble commented Mar 14, 2024

Summary of commits

This should create a new #major version

  • Add to_lvc_conventions and load_lvc
  • Introduce WaveformModesDict as wrapper to WaveformModes for Vijay-style indexing
  • Organize format_handlers into subdir
  • Add option to interpolate to find the exact max_norm_time, rather than closest index
  • Automatically restrict interpolation to use minimal set of times (to speed up interpolation to few steps)
  • Fix WaveformModes.interpolate frame bug
  • Pass group kwarg through to rpdmb.load; closes sxs.load('...') fails for ExtraWaveforms.h5 #80
  • Resolve path only when checking for existence; closes Using sxs.load with git-annex #84
  • Add coprecessing frame
  • Track ell_min and ell_max when slicing WaveformModes; closes Slicing WaveformModes objects #19
  • Add option to interpolate to find max norm time
  • Add option to check for out-of-control angular velocity
  • Add smooth transition / bump functions
  • Default to dropping times before 0 in RPDMB

Remaining tasks

I'm not sure how much these really need to be done before the code is merged, but these would be good:

  • If an SXS ID alone is given, just give the highest Lev and Strain_N2 (with kwargs for lev and extrap order)
  • Create new catalog. There are lots of little details that need to be sorted out one way for the old format, and a different way for the new one; it would be easier to just use the new one.

📚 Documentation preview 📚: https://sxs--89.org.readthedocs.build/en/89/

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 28.74109% with 300 lines in your changes are missing coverage. Please review.

Project coverage is 40.70%. Comparing base (5a89363) to head (35539d1).
Report is 8 commits behind head on main.

Files Patch % Lines
sxs/waveforms/format_handlers/lvc.py 12.76% 82 Missing ⚠️
sxs/waveforms/format_handlers/spectre_cce_v1.py 4.76% 60 Missing ⚠️
sxs/waveforms/waveform_modes.py 22.97% 53 Missing and 4 partials ⚠️
sxs/utilities/smooth_functions.py 39.50% 49 Missing ⚠️
...andlers/rotating_paired_diff_multishuffle_bzip2.py 38.23% 17 Missing and 4 partials ⚠️
sxs/utilities/formats.py 20.00% 6 Missing and 6 partials ⚠️
sxs/handlers.py 46.66% 6 Missing and 2 partials ⚠️
sxs/zenodo/api/deposit.py 0.00% 5 Missing ⚠️
sxs/utilities/sxs_identifiers.py 62.50% 2 Missing and 1 partial ⚠️
sxs/waveforms/alignment.py 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   42.22%   40.70%   -1.53%     
==========================================
  Files          71       73       +2     
  Lines        5579     5950     +371     
  Branches     1236     1222      -14     
==========================================
+ Hits         2356     2422      +66     
- Misses       3017     3308     +291     
- Partials      206      220      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moble moble force-pushed the lvc_integration branch 2 times, most recently from a236a52 to 9bc45c6 Compare April 29, 2024 19:15
Signed-off-by: Mike Boyle <michael.oliver.boyle@gmail.com>
Signed-off-by: Mike Boyle <michael.oliver.boyle@gmail.com>
Signed-off-by: Mike Boyle <michael.oliver.boyle@gmail.com>
@moble moble merged commit 2b06eac into main May 15, 2024
9 checks passed
@moble moble deleted the lvc_integration branch May 15, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using sxs.load with git-annex sxs.load('...') fails for ExtraWaveforms.h5 Slicing WaveformModes objects
2 participants