Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate language validators #27

Closed
MikeMcQuaid opened this issue Jun 22, 2016 · 3 comments
Closed

Alternate language validators #27

MikeMcQuaid opened this issue Jun 22, 2016 · 3 comments

Comments

@MikeMcQuaid
Copy link
Contributor

I ❤️ this bundle, thanks for it.

I'm thinking of adding a Rubocop validator for Ruby and shellcheck validator for Bash. Any thoughts on what the best way would be to implement these given they require external dependencies and not everyone may want to use them? A separate validator? A validator that people enable optionally?

Thanks!
@claylo
Copy link
Collaborator

claylo commented Jun 22, 2016

@MikeMcQuaid I'm a contributor/maintainer as well, and I agree that a more modular structure (similar to how the Atom guys have done theirs) would be beneficial.

@MikeMcQuaid
Copy link
Contributor Author

I'm not critiquing the current structure, for what it's worth, just wondering how to structure any PR/work on this so as to best get accepted.

@MikeMcQuaid MikeMcQuaid mentioned this issue Jul 2, 2016
Merged
@MikeMcQuaid
Copy link
Contributor Author

Closing in favour of PR in #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claylo @MikeMcQuaid