feat: Chafa integration #1066
Merged
feat: Chafa integration #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions, Yazi has been using Chafa provided by Überzug++ with the aim of minimizing external dependencies installed by users.
However, in practice, Überzug++ is not always available. It needs to obtain the pixel dimensions of the terminal when starting up, and in some terminal/desktop environments, it fails to do so, this results in Überzug++ crashing on startup, and is also not available on Windows.
But Chafa does not have these issues, so in Yazi v0.3, Chafa is added as an optional dependency and takes over ASCII art preview.
Also resolves #777