Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc should highlight performance features #38

Closed
zpz opened this issue Apr 6, 2022 · 1 comment
Closed

Doc should highlight performance features #38

zpz opened this issue Apr 6, 2022 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@zpz
Copy link

zpz commented Apr 6, 2022

From my perspective, I'm mainly interested in a performant alternative to the standard multiprocessing. While the benchmark is attractive, the readme does not say what tricks in the package make it faster, and make what kind of things faster. The progress bar, insights, init and such are nice to haves but not related to performance. The benchmarks without some explanation for the reason are not enough to make me try this package (for performance reasons).

@sybrenjansen
Copy link
Owner

Good point. I do refer to the blog post, but I'll add some more explanatory text about why it's faster and in what circumstances to the readme in the next update

@sybrenjansen sybrenjansen added the documentation Improvements or additions to documentation label Apr 12, 2022
sybrenjansen added a commit that referenced this issue Apr 25, 2022
* MPIRE now handles defunct child processes properly, instead of deadlocking (`#34`_)
* Added benchmark highlights to README (`#38`_)

Co-authored-by: sybrenjansen <sybren.jansen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants