update in_notebook check #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sybrenjansen
requested changes
Sep 3, 2021
sybrenjansen
requested changes
Sep 7, 2021
| @@ -142,7 +142,7 @@ def _progress_bar_handler(self, tqdm_connection_details: TqdmConnectionDetails, | |||
|
|
|||
| # In case we're running tqdm in a notebook we need to apply a dirty hack to get progress bars working. | |||
| # Solution adapted from https://github.com/tqdm/tqdm/issues/485#issuecomment-473338308 | |||
| in_notebook = 'IPython' in sys.modules and 'IPKernelApp' in sys.modules['IPython'].get_ipython().config | |||
| in_notebook = 'IPython' in sys.modules and sys.modules['IPython'].get_ipython() is not None and 'IPKernelApp' in sys.modules['IPython'].get_ipython().config | |||
There was a problem hiding this comment.
It's getting a bit out of hand with the big if statement. Perhaps we should simply let it fail and handle that instead:
try:
in_notebook = 'IPKernelApp' in sys.modules['IPython'].get_ipython().config
except (AttributeError, KeyError):
in_notebook = False
sybrenjansen
pushed a commit
that referenced
this pull request
Oct 13, 2021
…nd django installed (`#13`_)Fixed progress bar in a particular setting with iPython and django installed
|
I'm closing this PR because there hasn't been any activity in quite some time. I will add the fix proposed here to another PR today. |
sybrenjansen
added a commit
that referenced
this pull request
Oct 15, 2021
* Fixes #13 - Fixed progress bar in a particular setting with iPython and django installed * Fixes #15 - ``keep_alive`` now works even when the function to be called or any other parameter passed to the ``map`` function is changed * Moved ``enable_insights`` to the WorkerPool constructor. Using ``enable_insights`` from a ``map`` function is now deprecated and will be removed in MPIRE v2.6.0. * Restructured docs and updated several sections for Windows users. Co-authored-by: sybrenjansen <sybren.jansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ipython is installed with django, it'll sometimes try and use it automatically. when trying to run a django management command with ipython installed i was seeing