Include license file in source distribution #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Hmm, strange. I did change the Python version when building to 3.6, because it now defaults to 3.10 when 3.x is specified. 3.10 has some Windows support issues. Not sure if that's the reason, or that something changed in setuptools. Anyway, thanks for noticing :) |
sybrenjansen
approved these changes
Nov 19, 2021
|
@synapticarbors do you need a new version release for conda? If so, let me know |
|
That would be helpful if it's not a problem for you. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why, but v2.3.0 had the license file in the source distribution but 2.3.1 doesn't. I've added the license file to the
MANIFEST.into make sure it's included in future releases.