Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get NodeId for DomNode lazily (only when getting Hash for DomNode) #136

Merged
merged 2 commits into from Jun 30, 2021

Conversation

lukechu10
Copy link
Collaborator

No description provided.

@lukechu10 lukechu10 added the performance Performance related label Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Jun 30, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
+ 01_run1k               |       131.91 |   214.60 |  209.80 |   -2.24%
  02_replace1k           |       149.22 |   204.48 |  206.03 |   +0.76%
- 03_update10th1k_x16    |       235.36 |   314.25 |  334.96 |   +6.59%
  04_select1k            |        51.52 |    66.86 |   67.06 |   +0.31%
- 05_swap1k              |        77.02 |    82.87 |   91.42 |  +10.32%
- 06_remove-one-1k       |        31.01 |    31.40 |   32.34 |   +3.01%
+ 07_create10k           |      1342.82 |  8143.11 | 7672.18 |   -5.78%
+ 08_create1k-after1k_x2 |       307.83 |   534.10 |  517.11 |   -3.18%
- 09_clear1k_x8          |       201.11 |   254.52 |  266.88 |   +4.86%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.12%
+ 22_run-memory          |         1.50 |     2.25 |    2.02 |  -10.30%
+ 23_update5-memory      |         1.82 |     2.56 |    2.33 |   -8.94%
+ 24_run5-memory         |         2.11 |     2.81 |    2.53 |   -9.97%
  25_run-clear-memory    |         2.25 |     2.30 |    2.29 |   -0.27%
  31_startup-ci          |      2064.87 |  1956.80 | 1968.73 |   +0.61%
- 32_startup-bt          |        34.48 |    38.48 |   47.53 |  +23.54%
  34_startup-totalbytes  |       197.35 |   325.54 |  323.48 |   -0.63%

Workflow: [987598202](/sycamore-rs/sycamore/actions/runs/987598202) *Adding new commits will generate a new report*

@lukechu10 lukechu10 added performance Performance related and removed performance Performance related labels Jun 30, 2021
@github-actions
Copy link

github-actions bot commented Jun 30, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
  01_run1k               |        99.58 |   168.66 |  166.68 |   -1.18%
+ 02_replace1k           |       108.27 |   151.84 |  145.95 |   -3.87%
- 03_update10th1k_x16    |       186.16 |   194.45 |  204.22 |   +5.02%
+ 04_select1k            |        28.45 |    46.07 |   45.07 |   -2.16%
  05_swap1k              |        54.19 |    56.83 |   57.67 |   +1.47%
- 06_remove-one-1k       |        21.98 |    23.31 |   24.07 |   +3.25%
+ 07_create10k           |      1032.22 |  6348.80 | 6141.26 |   -3.27%
  08_create1k-after1k_x2 |       229.66 |   372.19 |  377.19 |   +1.34%
+ 09_clear1k_x8          |       151.35 |   206.79 |  201.69 |   -2.46%
  21_ready-memory        |         1.02 |     1.02 |    1.02 |   -0.12%
+ 22_run-memory          |         1.50 |     2.25 |    2.02 |  -10.30%
+ 23_update5-memory      |         1.82 |     2.57 |    2.33 |   -9.08%
+ 24_run5-memory         |         2.11 |     2.81 |    2.61 |   -7.17%
+ 25_run-clear-memory    |         2.25 |     2.30 |    2.21 |   -3.87%
  31_startup-ci          |      1853.67 |  1968.23 | 1955.75 |   -0.63%
- 32_startup-bt          |        24.51 |    31.13 |   35.86 |  +15.17%
  34_startup-totalbytes  |       197.35 |   325.54 |  323.48 |   -0.63%

Workflow: [987840097](/sycamore-rs/sycamore/actions/runs/987840097) *Adding new commits will generate a new report*

@lukechu10 lukechu10 merged commit d8aff0c into master Jun 30, 2021
@lukechu10 lukechu10 deleted the domnode-id-lazy branch June 30, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant