Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that Trunk needs a HTML source file #206

Merged
merged 1 commit into from Aug 9, 2021

Conversation

Yoshanuikabundi
Copy link
Contributor

Hi! Just exploring Sycamore (looks cool so far) and ran into trouble running the hello world example, which doesn't describe creating index.html, which Trunk needs. Following the current instructions gives an error:

$ trunk serve                        
Error: error getting canonical path to source HTML file "index.html"

Caused by:
    No such file or directory (os error 2)

So I thought I'd fix that :)

The page in question also previously said:

In fact, the Hello World program in Sycamore is but slightly longer than the console version!

But the console version is not described. So I've removed this sentence.

Finally, the description of the sycamore repo on Github is

A reactive DOM library for Rust in WASM

I only mention this in case you wanted to update it to "Sycamore is a modern VDOM-less web library with fine-grained reactivity in Rust and WebAssembly." to match the readme.

Thanks!

Hi! Just exploring Sycamore (looks cool so far) and ran into trouble running the hello world example, which doesn't describe creating index.html, which Trunk needs. Following the current instructions gives an error:

```shell
$ trunk serve                        
Error: error getting canonical path to source HTML file "index.html"

Caused by:
    No such file or directory (os error 2)
```

So I thought I'd fix that :)

The page in question also previously said:

> In fact, the Hello World program in Sycamore is but slightly longer than the console version!

But the console version is not described. So I've removed this sentence.

Finally, the description of the sycamore repo on Github is

> A reactive DOM library for Rust in WASM 

I only mention this in case you wanted to update it to "Sycamore is a modern VDOM-less web library with fine-grained reactivity in Rust and WebAssembly." to match the readme.

Thanks!
@lukechu10
Copy link
Collaborator

LGTM. There definitely needs some consistency between the Sycamore taglines. Maybe "blazing-fast Rust library for creating web applications (with WebAssembly)" or something of the like.

@lukechu10 lukechu10 added the A-docs Area: documentation label Aug 9, 2021
@lukechu10 lukechu10 merged commit 422ddec into sycamore-rs:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants