Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating components with the Component trait #213

Merged
merged 5 commits into from Aug 21, 2021

Conversation

lukechu10
Copy link
Collaborator

No description provided.

@lukechu10 lukechu10 added BREAKING CHANGE Breaking changes introduced in this PR A-components Area: components and UI abstraction performance Performance related labels Aug 20, 2021
@github-actions
Copy link

github-actions bot commented Aug 20, 2021

Finished dev [unoptimized + debuginfo] target(s) in 0.01s
 Running `target/debug/results_diff`

Benchmark Report

  • wasm-bindgen: the performance goal
  • baseline: performance of sycamore-baseline (typically latest master)
  • update: performance of sycamore (typically recent changes)
  • diff: measures the improvement of update over the baseline
@@                         Performance Diff                          @@

##                       | wasm-bindgen | baseline |  update |  diff ##
#######################################################################
- 01_run1k               |       124.37 |   158.97 |  166.99 |   +5.04%
  02_replace1k           |       144.31 |   172.98 |  176.42 |   +1.99%
- 03_update10th1k_x16    |       319.97 |   330.21 |  351.52 |   +6.45%
+ 04_select1k            |        43.27 |    54.03 |   52.01 |   -3.75%
  05_swap1k              |        83.50 |    86.42 |   87.10 |   +0.79%
  06_remove-one-1k       |        30.08 |    31.48 |   31.38 |   -0.34%
  07_create10k           |      1278.29 |  1700.61 | 1687.44 |   -0.77%
  08_create1k-after1k_x2 |       293.97 |   339.31 |  336.48 |   -0.84%
  09_clear1k_x8          |       209.11 |   224.34 |  222.51 |   -0.81%
  21_ready-memory        |         1.03 |     1.02 |    1.02 |   -0.00%
  22_run-memory          |         1.51 |     1.84 |    1.84 |   +0.03%
  23_update5-memory      |         1.83 |     2.12 |    2.12 |   -0.00%
  24_run5-memory         |         2.11 |     2.37 |    2.37 |   -0.00%
  25_run-clear-memory    |         2.25 |     2.29 |    2.29 |   +0.00%
  31_startup-ci          |      1821.13 |  1977.92 | 2019.96 |   +2.13%
+ 32_startup-bt          |        85.97 |   160.74 |   81.78 |  -49.12%
  34_startup-totalbytes  |       197.35 |   296.50 |  296.50 |   +0.00%

Workflow: 1151610434
Adding new commits will generate a new report

@lukechu10 lukechu10 removed the performance Performance related label Aug 21, 2021
@sycamore-rs sycamore-rs deleted a comment from github-actions bot Aug 21, 2021
@lukechu10 lukechu10 enabled auto-merge (squash) August 21, 2021 01:46
@lukechu10 lukechu10 merged commit 4782844 into master Aug 21, 2021
@lukechu10 lukechu10 deleted the generic-component-create branch August 21, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-components Area: components and UI abstraction BREAKING CHANGE Breaking changes introduced in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant